Skip to content

Support Forums: Add hover underline to homepage footer heading links.#615

Open
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:forums-footer-link-underline
Open

Support Forums: Add hover underline to homepage footer heading links.#615
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:forums-footer-link-underline

Conversation

@t-hamano
Copy link
Copy Markdown

I noticed that only the forum archive page is missing the underline when hovering over the footer links.

image

I suspect this is due to a missing hover style, similar to the one present in Developer 2023.

https://github.com/WordPress/wporg-developer/blob/d59ed7c2ee16f2831f9878cf802efec7ad71ac47/source/wp-content/themes/wporg-developer-2023/src/style/style.scss#L116-L118

By the way, this link color itself is incorrect. It should actually be as follows.

Actual Expected
image image

I haven't looked into this matter in detail yet, but it seems that the CSS selector for the link element is not being generated correctly. The actual existing hash value is not present in the generated style.

<style id="core-block-supports-inline-css">
.wp-elements-e2d6371551f640c35c9d53e50ae8c6e2 a:where(:not(.wp-element-button)) {
    color: var(--wp--preset--color--blueberry-2);
}

.wp-elements-a5f5f873308e52bc5bfddbd348d9f427 a:where(:not(.wp-element-button)) {
    color: var(--wp--preset--color--blueberry-2);
}
</style>

<h3 class="wp-block-heading wp-elements-3192939fc4a03bd1165c0016a67e978f"><a href="">Documentation</a></h3>

The homepage footer heading links had no visual affordance on hover.
Restore the underline on `:hover` so the link state matches the rest
of the site's link behavior.
Copilot AI review requested due to automatic review settings April 26, 2026 12:43
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a hover underline style for the “More resources” footer heading links used on the Support Forums archive/homepage footer block, aligning the interaction styling with other parts of the site.

Changes:

  • Add :hover underline styling for .forums-homepage-footer .wp-block-heading a.
  • Rebuild compiled CSS outputs for both LTR and RTL stylesheets.
  • Update the generated CSS source map.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/sass/site/_site.scss Adds the Sass rule for footer heading link hover underline.
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css Compiled LTR CSS output reflecting the new hover rule.
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style-rtl.css Compiled RTL CSS output reflecting the new hover rule.
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css.map Updated sourcemap generated during the rebuild.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.forums-homepage-footer .wp-block-heading a {
text-decoration: none;

&:hover {
text-decoration: none;

&:hover {
text-decoration-line: underline;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants