Support Forums: Add hover underline to homepage footer heading links.#615
Support Forums: Add hover underline to homepage footer heading links.#615t-hamano wants to merge 1 commit into
Conversation
The homepage footer heading links had no visual affordance on hover. Restore the underline on `:hover` so the link state matches the rest of the site's link behavior.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
Adds a hover underline style for the “More resources” footer heading links used on the Support Forums archive/homepage footer block, aligning the interaction styling with other parts of the site.
Changes:
- Add
:hoverunderline styling for.forums-homepage-footer .wp-block-heading a. - Rebuild compiled CSS outputs for both LTR and RTL stylesheets.
- Update the generated CSS source map.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/sass/site/_site.scss |
Adds the Sass rule for footer heading link hover underline. |
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css |
Compiled LTR CSS output reflecting the new hover rule. |
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style-rtl.css |
Compiled RTL CSS output reflecting the new hover rule. |
wordpress.org/public_html/wp-content/themes/pub/wporg-support-2024/style.css.map |
Updated sourcemap generated during the rebuild. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .forums-homepage-footer .wp-block-heading a { | ||
| text-decoration: none; | ||
|
|
||
| &:hover { |
| text-decoration: none; | ||
|
|
||
| &:hover { | ||
| text-decoration-line: underline; |
I noticed that only the forum archive page is missing the underline when hovering over the footer links.
I suspect this is due to a missing hover style, similar to the one present in Developer 2023.
https://github.com/WordPress/wporg-developer/blob/d59ed7c2ee16f2831f9878cf802efec7ad71ac47/source/wp-content/themes/wporg-developer-2023/src/style/style.scss#L116-L118
By the way, this link color itself is incorrect. It should actually be as follows.
I haven't looked into this matter in detail yet, but it seems that the CSS selector for the link element is not being generated correctly. The actual existing hash value is not present in the generated style.