Skip to content

feat(Discussion): Hide hidden response content in teacher summary#2308

Merged
breity merged 3 commits into
developfrom
hide-hidden-posts-in-teacher-discussion-summary
May 2, 2026
Merged

feat(Discussion): Hide hidden response content in teacher summary#2308
breity merged 3 commits into
developfrom
hide-hidden-posts-in-teacher-discussion-summary

Conversation

@breity
Copy link
Copy Markdown
Member

@breity breity commented Apr 30, 2026

Changes

  • Hide the content of Discussion posts and replies (comments) that have been hidden for students by teacher in the Discussion summary view in the Teacher Tools.
  • Teachers can click/tap to view and hide hidden response content.
  • Add tests for ClassResponseTeacherComponent.

Test

  • Make sure posts and comments that have been marked as hidden by teacher are hidden by default in teacher summary view.
  • Teachers can show and hide hidden response content by clicking/tapping.
  • Hiding/showing posts and comments via the "Hide from students" and "Show to students" buttons works as before.

- Allow teacher to view hidden posts and replies
- Add tests
@breity breity requested a review from hirokiterashima April 30, 2026 20:49
@breity breity self-assigned this Apr 30, 2026
@breity breity added the enhancement New feature of any size or improvement (UI, performance, security) label Apr 30, 2026
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Apr 30, 2026

❌ 2 blocking issues (2 total)

Tool Category Rule Count
qlty Duplication Found 17 lines of similar code in 2 locations (mass = 124) 2

component['hidePost'](component.response);
expect(spy).not.toHaveBeenCalled();
});
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 lines of similar code in 2 locations (mass = 124) [qlty:similar-code]

component['showPost'](component.response);
expect(spy).not.toHaveBeenCalled();
});
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 lines of similar code in 2 locations (mass = 124) [qlty:similar-code]

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Apr 30, 2026

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New Coverage rating: A
...ion/class-response-teacher/class-response-teacher.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breity breity merged commit 0346081 into develop May 2, 2026
4 checks passed
@breity breity deleted the hide-hidden-posts-in-teacher-discussion-summary branch May 2, 2026 00:44
@hirokiterashima
Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.227.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants