Skip to content

feat(TeacherTools): Restore Match summary organize by bucket#2307

Merged
breity merged 5 commits intodevelopfrom
restore-match-summary-organize-by-bucket
May 2, 2026
Merged

feat(TeacherTools): Restore Match summary organize by bucket#2307
breity merged 5 commits intodevelopfrom
restore-match-summary-organize-by-bucket

Conversation

@breity
Copy link
Copy Markdown
Member

@breity breity commented Apr 24, 2026

Changes

  • Put back the organize by bucket view for Match (Sort) activity summaries in the teacher tools.
  • Add a toggle to switch between the item and bucket views.

Test

  • Make sure item view works as before for Match teacher summaries.
  • Make sure bucket view works properly and the buckets are sorted by total number of times any items were moved to each bucket.

@breity breity requested a review from hirokiterashima April 24, 2026 18:50
@breity breity self-assigned this Apr 24, 2026
@breity breity added enhancement New feature of any size or improvement (UI, performance, security) feature request someone requests a feature labels Apr 24, 2026
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Apr 24, 2026

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
New Coverage rating: A
...tives/teacher-summary-display/summary-data/MatchSummaryData.ts100.0%
New Coverage rating: A
...splay/match-summary-display/match-summary-display.component.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future, it'd be nice to see the student names when we hover over the person icon, like we do in the idea summary view.

@breity breity merged commit 150219d into develop May 2, 2026
1 check passed
@breity breity deleted the restore-match-summary-organize-by-bucket branch May 2, 2026 04:30
@hirokiterashima
Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.228.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) feature request someone requests a feature released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants