Add summary columns, column toggles, and per-snapshot report drawer to multi-report#6
Merged
Merged
Conversation
…o multi-report The multi-report command rendered only Asset Bundle / Serialized File / PMR metrics and offered no high-level memory picture or way to drill into a single snapshot. This turns it into a triage dashboard: - Summary columns: per snapshot, show the Allocated Memory Distribution resident breakdown (Total, Native, Managed, Executables & Mapped, Graphics, Untracked) read from each database's summary_metrics table. Resident columns are visible by default; the committed/allocated equivalents are rendered but hidden behind a toggle. Categories with no measurable resident size (Graphics, Untracked) and databases exported before summary_metrics existed render N/A. - Column show/hide toolbar: checkboxes toggle each column group on and off; group-header and session-header colspans recompute live, and within-session sorting is unaffected. - Per-snapshot report drawer: a full single-snapshot report is generated for each database and a row click opens it in an inline slide-in iframe drawer, with an "open in new tab" pop-out fallback. Add --no-reports for the faster table-only output. Reuse the existing summary_metrics read by extracting SummaryMetricsDbReader (shared by the summary command), and reuse ReportBuilder/ReportRenderer for the per-snapshot reports. Refactor MultiSnapshotHtmlRenderer to a column-descriptor model so the wider, toggleable table stays maintainable. Make the single-report Contents nav responsive so it no longer overlaps content when viewed in the narrow drawer iframe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-report command rendered only Asset Bundle / Serialized File / PMR metrics and offered no high-level memory picture or way to drill into a single snapshot. This turns it into a triage dashboard:
Reuse the existing summary_metrics read by extracting SummaryMetricsDbReader (shared by the summary command), and reuse ReportBuilder/ReportRenderer for the per-snapshot reports. Refactor MultiSnapshotHtmlRenderer to a column-descriptor model so the wider, toggleable table stays maintainable. Make the single-report Contents nav responsive so it no longer overlaps content when viewed in the narrow drawer iframe.