Skip to content

Fix grib CDM index update logic#1551

Merged
lesserwhirls merged 1 commit intoUnidata:maint-5.xfrom
lesserwhirls:gidx
Apr 27, 2026
Merged

Fix grib CDM index update logic#1551
lesserwhirls merged 1 commit intoUnidata:maint-5.xfrom
lesserwhirls:gidx

Conversation

@lesserwhirls
Copy link
Copy Markdown
Member

@lesserwhirls lesserwhirls commented Apr 27, 2026

Description of Changes

isUpdateNeeded only tells you for sure that a collection does not need updated; if isUpdateNeeded returns true, there are still more checks that need to happen before we know that an update is actually needed.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

isUpdateNeeded only tells you for sure that a collection does not need
updated; if isUpdateNeeded returns true, there are still more checks
that need to happen before we know that an update is actually needed.
@lesserwhirls lesserwhirls added this to the 5.10.0 milestone Apr 27, 2026
@lesserwhirls lesserwhirls added bug Something isn't working iosp: grib grib file format labels Apr 27, 2026
@lesserwhirls lesserwhirls marked this pull request as ready for review April 27, 2026 20:07
@lesserwhirls lesserwhirls merged commit 0b44254 into Unidata:maint-5.x Apr 27, 2026
15 checks passed
@lesserwhirls lesserwhirls deleted the gidx branch April 27, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working iosp: grib grib file format

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant