Skip to content

feat(ui5): Add OPA5 guidelines as Skills#64

Merged
flovogt merged 21 commits into
UI5:mainfrom
kineticjs:opa5
Jun 10, 2026
Merged

feat(ui5): Add OPA5 guidelines as Skills#64
flovogt merged 21 commits into
UI5:mainfrom
kineticjs:opa5

Conversation

@kineticjs

@kineticjs kineticjs commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Adding skills for OPA5 integration testing.

JIRA: BGSOFUIPIRIN-6914

@kineticjs kineticjs marked this pull request as ready for review June 2, 2026 08:01
@kineticjs kineticjs force-pushed the opa5 branch 2 times, most recently from b3fb084 to 1b917cd Compare June 2, 2026 08:24
@d3xter666

d3xter666 commented Jun 2, 2026

Copy link
Copy Markdown
Member

Hi @kineticjs ,

Please also add plugin.json files for the skill. You can have a look at: https://github.com/UI5/plugins-coding-agents/tree/main/plugins/ui5/

They are pretty much the same. The only diff is that plugins/ui5/plugin.json has skills property.
We need this, so that skills are correctly discoverable under the agents

dobrinyonkov
dobrinyonkov reviewed Jun 3, 2026
View reviewed changes
Comment thread plugins/ui5/skills/opa5/SKILL.md Outdated
Comment thread plugins/ui5/skills/opa5/SKILL.md Outdated
Comment thread plugins/ui5/skills/opa5/SKILL.md Outdated
Comment thread plugins/ui5/skills/ui5-best-practices-opa5/references/configuration.md
Comment thread plugins/ui5/skills/ui5-best-practices-opa5/references/handle-multiple-views.md
@dobrinyonkov

dobrinyonkov commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Hey, I ran the official Claude Code skill-development skill and the skill-reviewer agent (both from Anthropic's plugin-dev plugin) against this skill, and they flagged a few potential issues we might want to address. Inline comments above.

@kineticjs kineticjs closed this Jun 3, 2026
@kineticjs kineticjs reopened this Jun 3, 2026
@kineticjs

kineticjs commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @d3xter666 , @RandomByte ,
The plugin.json files and the are now also updated. Do you have more comments and should we add more reviewers from the Core team?
Thnx

d3xter666
d3xter666 previously approved these changes Jun 8, 2026
View reviewed changes

@d3xter666 d3xter666 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandomByte RandomByte requested a review from flovogt June 8, 2026 12:15
flovogt
flovogt requested changes Jun 9, 2026
View reviewed changes
Comment thread plugins/ui5/skills/opa5/SKILL.md Outdated
Comment thread plugins/ui5/skills/opa5/references/enable-testrecorder-tooling.md Outdated
Comment thread plugins/ui5/skills/opa5/references/enable-testrecorder-tooling.md Outdated
Comment thread plugins/ui5/README.md Outdated
Comment thread plugins/ui5/skills/ui5-best-practices-opa5/references/enable-testrecorder-tooling.md
Comment thread plugins/ui5/skills/opa5/references/handle-multiple-views.md Outdated
kineticjs and others added 5 commits June 9, 2026 10:15
@kineticjs @flovogt
feat(ui5): Rename skill to existing convention
e59d241 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@kineticjs @flovogt
feat(ui5): Improve text
b89dadd 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@kineticjs @flovogt
feat(ui5): Improve title
ed3d277 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@kineticjs @flovogt
feat(ui5): Improve title
7efc160 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@kineticjs
feat(ui5): Adapt TestRecorder example to use async/await
1537e99
kineticjs and others added 2 commits June 9, 2026 10:57
@kineticjs kineticjs requested a review from flovogt June 9, 2026 08:53
flovogt
flovogt requested changes Jun 10, 2026
View reviewed changes
Comment thread plugins/ui5/skills/ui5-best-practices-opa5/references/configuration.md Outdated
Comment thread plugins/ui5/skills/ui5-best-practices-opa5/references/enable-testrecorder-tooling.md Outdated
Comment thread plugins/ui5/skills/ui5-best-practices-opa5/references/enable-testrecorder-tooling.md
kineticjs and others added 3 commits June 10, 2026 11:16
@kineticjs @flovogt
feat(ui5): Adapt to modern syntax
4c7d3e0 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@kineticjs @flovogt
feat(ui5): Adapt to modern syntax
b984a94 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@kineticjs
feat(ui5): Add missing use strict
59a269b
flovogt
flovogt approved these changes Jun 10, 2026
View reviewed changes

@flovogt flovogt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovogt flovogt merged commit 1ddbcd2 into UI5:main Jun 10, 2026
4 checks passed
@openui5bot openui5bot mentioned this pull request Jun 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flovogt flovogt flovogt approved these changes

@d3xter666 d3xter666 d3xter666 left review comments

+1 more reviewer

@dobrinyonkov dobrinyonkov dobrinyonkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kineticjs @d3xter666 @dobrinyonkov @flovogt