-
Notifications
You must be signed in to change notification settings - Fork 4
fix(doctor): correct ℹ️ icon and generalize hook example from PR #56 review #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -659,9 +659,9 @@ Report a single summary line per skill (not per field) to keep output scannable. | |
| Hook permissions are the only thing doctor auto-fixes (with user confirmation), and | ||
| only in source-repo context where the script files are present: | ||
|
|
||
| "⚠️ todo-persist.sh is not executable. Fix now? [y/N]" | ||
| "⚠️ <hook-name>.sh is not executable. Fix now? [y/N]" | ||
|
|
||
| If yes: `chmod +x plugins/core/hooks/todo-persist.sh` | ||
| If yes: `chmod +x plugins/core/hooks/<hook-name>.sh` | ||
|
|
||
| For all other issues, report and direct to the appropriate fix command. Don't modify | ||
| JSON files, settings, or symlinks without explicit user instruction. | ||
|
|
@@ -701,7 +701,7 @@ Context: source repo (plugins/core/ detected) | |
| ### Skill Frontmatter | ||
| ✅ brainstorming — name, description, triggers, next-skill: brainstorm-synthesis (found) | ||
| ✅ systematic-debugging — name, description, triggers, next-skill: verify-fix (found) | ||
| ⚠️ mcp-debug — triggers field present, stability: experimental | ||
| ℹ️ mcp-debug — triggers field present, stability: experimental | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Changing Useful? React with 👍 / 👎. |
||
|
|
||
| --- | ||
| ## Summary | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary warning count inconsistent after icon change
Medium Severity
The example summary line still says
2 warnings ⚠️, but changing themcp-debugline from⚠️toℹ️means there's now only 1 warning (todo-persist.sh) in the example output. The count wasn't updated to match, so the example is internally inconsistent. Since this is a spec/prompt that guides LLM behavior, the mismatched count could teach models to produce incorrect summary tallies at runtime.Additional Locations (1)
plugins/core/commands/ai-coding-config.md#L703-L704Reviewed by Cursor Bugbot for commit 0bc0588. Configure here.