Add support for custom items#90
Merged
Merged
Conversation
rafaeljusto
reviewed
May 28, 2026
rafaeljusto
left a comment
rafaeljusto
left a comment
Contributor
There was a problem hiding this comment.
Hey Dan, added some suggestions. Let me know if you want me to patch those.
Co-authored-by: Rafael Dantas Justo <rafael.justo@teamwork.com>
Contributor
Author
|
If you have time that would be great @rafaeljusto ❤️ |
- Replace stringly-typed Include/OrderBy filters with typed enums (CustomItemSideload, CustomItemOrderBy, CustomItemRecordSideload, CustomItemRecordOrderBy) and align their values with the server-side enums in projectsapigo (pkg/enum/customitem*.go). - Drop OrderBy from the field list filters — the server's field endpoint has no orderBy query param, only orderMode. - Add the archived state to CustomItemState and CustomItemRecordState to match the three states the server exposes; add the missing "users" sideload on record list/get. - Always send skipCounts=true on the v3 list endpoints and collapse Meta to just HasMore — total counts are derivable from (page * pageSize) + 1. - Promote NullableInt64 to the root twapi package so it can be reused across resources. - Document the typed-enum and skipCounts conventions in AGENTS.md and list NullableInt64 in the common types table.
rafaeljusto
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description