Add Node Manager#929
Closed
camielvs wants to merge 1 commit into
Closed
Conversation
This was referenced Sep 20, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1166ce3 to
d738a0a
Compare
34238bb to
11d5dce
Compare
d738a0a to
8bba722
Compare
7dcc9ba to
eae31b0
Compare
8bba722 to
4eed892
Compare
This was referenced Sep 29, 2025
Closed
4eed892 to
e65db05
Compare
eae31b0 to
9511aeb
Compare
This was referenced Oct 2, 2025
e65db05 to
d13ac40
Compare
9511aeb to
a6337e1
Compare
d13ac40 to
43a282b
Compare
43a282b to
3e1ef82
Compare
47571c0 to
bf97171
Compare
3 tasks
bf97171 to
a82859b
Compare
f40af72 to
7ce2817
Compare
e9bdbe3 to
b5e9bcd
Compare
7ce2817 to
e8167cb
Compare
b5e9bcd to
e83ef69
Compare
e8167cb to
e64dccf
Compare
e83ef69 to
c754609
Compare
e64dccf to
8622de6
Compare
c754609 to
45adef9
Compare
0e9a8ad to
13d6255
Compare
45adef9 to
c099a92
Compare
13d6255 to
e98225e
Compare
8a10101 to
8be46ba
Compare
7ab0232 to
68217dd
Compare
8be46ba to
609e209
Compare
3 tasks
68217dd to
f148c44
Compare
609e209 to
a8907f7
Compare
Collaborator
Author
|
Closed in favour of v2 Editor migration. See #2028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds a new top-level class
NodeManagerto handle conversion between static ReactFlow node ids and potentially non-static task ids.Node ids are a randomly generated unique id internal to the app and specifically used to maintain ReactFlow state. The Node Manager creates, stores and, when necessary, removes these ids and maps them 1:1 with the relevant
refId, whererefIdis any key (though typically ataskId,inputNameoroutputName.ReactFlow Node ids will now be related to tasks as follows:
node id<--Node Manager-->task idnode id<--Node Manager-->input namenode id<--Node Manager-->output nameTask inputs & task outputs are are mapped via their
Handlerelative to the task/object they are on.No change to app functionality. Implementation of the node manager will come in upstack PRs.
Related Issue and Pull requests
Progresses https://github.com/Shopify/oasis-frontend/issues/261
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
This PR adds a bunch of code without tying it into the existing app so it cannot be test through UI.
Review the test file to see if the core functionality works as expected.
Additional Comments