feat: MongoDB replica set multi-host connections#866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HostListFieldRowUI component with add/remove host:port rows in the connection formFieldType.hostListandFieldSection.connectionin PluginKit for generic multi-host field supportmongodb://h1:27017,h2:27017,h3:27017/db)Changes
PluginKit —
FieldType.hostList,FieldSection.connection(no ABI bump needed)MongoDB Plugin —
mongoHostsfield, URI builder handles comma-separated hosts, driver prefersmongoHostsfrom additionalFieldsConnection Form —
HostListFieldRowmulti-row editor, host/port derived from first entry on save, legacy connection migration on load, SSH + multi-host warningURL Parser —
parseMultiHostMongoDB()for proper authority parsing without URLComponents,multiHostfield onParsedConnectionURLDisplay —
hostDisplayStringonDatabaseConnectionshowshost1:27017 (+2 more)for multi-hostDocs — Replica Set / Multi-Host section in
docs/databases/mongodb.mdxTest plan
mongodb://h1:27017,h2:27017,h3:27017/db?replicaSet=myrs— verify all hosts populatedmongodb://user:pass@host1:27017/db— verify single host worksmongodb+srv://cluster.mongodb.net/db— verify SRV still works (no multi-host path)host1:27017 (+2 more)for multi-host connections