You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe in John, but wouldn't it better to rebase upon the recent release instead? There is a tiny chance that DOSBox-X is now in the middle of being fixed of some newly created bugs.
I believe in John, but wouldn't it better to rebase upon the recent release instead? There is a tiny chance that DOSBox-X is now in the middle of being fixed of some newly created bugs.
You're right, I should rebase to an official release. However, instead of reverting commits after the last one, I rather wait until the next release and forward-apply those. He's release pretty often anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing the DOSBox-X core to: joncampbell123/dosbox-x@37dd005
Check if completed: