Skip to content

ci: gate visual regression tests by path#2248

Open
dancormier wants to merge 14 commits intomainfrom
dcormier/gate-visual-regression-tests
Open

ci: gate visual regression tests by path#2248
dancormier wants to merge 14 commits intomainfrom
dcormier/gate-visual-regression-tests

Conversation

@dancormier
Copy link
Copy Markdown
Contributor

@dancormier dancormier commented Apr 28, 2026

Summary

Gates the visual regression suite so it only runs when visual-test-relevant files change. It also updates our workflows to use node v24 (via actions/setup-node@v5)

Related Issue

STACKS-887

Changes

  • Adds a dorny/paths-filter check for visual regression relevant paths.
  • Moves visual regression tests into a dedicated gated workflow job.
  • Preserves release behavior when the visual regression job is intentionally skipped.

Testing

Verify test runs in this PR

Verify visual regression tests complete successfully when changes are present in packages/stacks-classic

  • Change to packages/stacks-classic/README.md: bd76203
  • Commit with completed workflow that includes visual regression test run: b69ece2
  • Successful visual regression test run
    • Note: it runs "Detect changes", which reports that there are changes to Stacks Classic, with the visual regression tests running after

Verify visual regression tests are skipped when changes are not present in packages/stacks-classic

Manually testing

  • In this PR, push a small change to a file within packages/stacks-classic (I suggest adding a comment to README.md
  • Verify the visual regression job runs and completes successfully
  • Revert your change and verify that the visual regression job is skipped

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2026

⚠️ No Changeset found

Latest commit: ec365b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 28, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit ec365b4
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/69f256db908e990008a24886
😎 Deploy Preview https://deploy-preview-2248--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread .github/workflows/test-visual-regression.yml Fixed
Comment thread .github/workflows/test-visual-regression.yml Fixed
Comment thread .github/workflows/test-visual-regression.yml Dismissed
Comment thread .github/workflows/test-visual-regression.yml Dismissed
@dancormier dancormier marked this pull request as ready for review April 29, 2026 19:17
@dancormier dancormier requested a review from a team as a code owner April 29, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants