fix: bump Socket SDK version, handle missing diff scores#193
Merged
Conversation
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.2.86.dev1Docker image: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Chris Johnson (johnsonch)
approved these changes
Apr 24, 2026
Chris Johnson (johnsonch)
left a comment
There was a problem hiding this comment.
Thank you for doing this!
Phil Gran (philgran)
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the CLI to
socketdev>=3.0.33,<4.0.0to pick up the SDK fix for unknown alert categories, and harden dependency overview rendering so PR comments no longer crash when diff artifacts have missing or null score data.Problem
"other". That is fixed insocketdev 3.0.33, so the CLI needs to consume that release.score/scoresset toNone. The comment renderer assumedadded.scoreswas always a dict and called.get(...)on it.Fix
socketdev>=3.0.33,<4.0.02.2.86to prepare for new releasescore=Noneto an empty score map in the CLI model layerTest plan
uv run --refresh --extra test pytest tests/unit/test_dependency_overview.py tests/core/test_package_and_alerts.py -qAdded regression coverage for:
Package.from_diff_artifact(...)normalizingscore=NoneAlso fixes: SocketDev/socket-sdk-python#78