Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR exposes the resolved declaration for method receivers. When there's no receiver or it's unresolved, we return
nil. This helps us provide more accurate find references in the Ruby LSP.Note: exposing the receiver as
Declaration?is probably not 100% correct, but since we cannot know the type of method receivers until there's type inference, it's a decent mid-point.I also prototyped changing the receiver to be a constant reference ID (instead of a name ID), but it leads to a lot of other issues. For example:
Maybe, in the future, the
selfwould be something like aTypeRef? Anyway, it's clearly too early to model this so I went with a compromise.