Added Rich Color Configuration#515
Conversation
|
Hey there, I tested this PR locally on Linux Mint 22.1 with a Logitech G733 ( What worked correctly on real hardware:
However, I found a behavioral issue with combined lighting state:
This also matches the current implementation in
So from my testing, isolated static color control looks good, and the animation modes themselves do work, but combined color/mode/brightness state is not fully preserved yet on I think the underlying issue is state composition rather than the raw packet format itself. A cleaner fix would probably be to store the current lighting state in the device instance (RGB, brightness, mode, speed, enabled) and have all of |
Changes made
Implemented advanced RGB lighting control for the Logitech G733 family (via the existing
LogitechG633Familydevice handler).CAP_LIGHT_COLOR,CAP_LIGHT_BRIGHTNESS,CAP_LIGHT_MODE,CAP_LIGHT_SPEED.HIDDevicewith:setLightColor(red, green, blue)setLightBrightness(1-100)setLightMode(static|breathing|wave)setLightSpeed(1-100)(used for breathing/wave)lib/devices/logitech_g633_g933_935.hpp.red/green/bluematch expected colors.--light-color(named colors,#RRGGBB, orR,G,B)--light-brightness <1-100>--light-mode <static|breathing|wave>--light-speed <1-100>cli/main.cpp.docs/FEATURE_REQUEST_G733_LIGHTING_ENHANCEMENTS.md(motivation + usage + test plan)Usage examples (one setting at a time):
Related context:
Checklist