sha-crpypt, ballon-hash, bcrypt-pbkdf, and yescrypt benchmarks#865
Open
WingZer0o wants to merge 11 commits into
Open
sha-crpypt, ballon-hash, bcrypt-pbkdf, and yescrypt benchmarks#865WingZer0o wants to merge 11 commits into
WingZer0o wants to merge 11 commits into
Conversation
Contributor
Author
|
Converted this to a draft and will be implementing the other benchmarks in this branch to eliminate sparse PRs.
|
WingZer0o
changed the title
Member
|
@WingZer0o sorry, it's not that these aren't useful but they're kind of a low priority right now |
Contributor
Author
|
@tarcieri Ah no worries, I wasn't sure so I just closed it. I have reopened and will fix the merge conflicts at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sha-crypt was missing some benchmarks. I propose that all of the individual password hashing crates have a few benchmarks in them based off the test vectors that are being put in. I can do the rest in a subsequent PR.