Conversation
micahrj
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
x11crate with itsx11-dlcounterpart, which allows to dynamically link against the various X11 libraries we depend on.(Namely:
libX11,libGLX,libX11-xcb,libxcb, and probably a few more)This brings us more in line with the rest of the Rust GUI ecosystem (e.g.
winit,glutin,wryall rely onx11-dlrather thanx11), as well as a rather big part of the audio plugins ecosystem (most notably, JUCE dynamically loads all Xlib symbols instead of statically linking againstlibX11).For us, the biggest improvement is that it allows plugins that use
baseviewto still function on linux systems that lack one or more X libraries (only GUI creation will fail, which AFAIK most hosts handle gracefully enough).This PR also fixes an use-after-free bug which could occur if the
GLContextoutlived itsWindow(it was using a raw display pointer, now replaced with anRcto theXcbConnection).This and related changes also removes quite a few uses of
unsafethroughout the library.