Fix: use mailto: scheme instead of email: for Andrew Tridgell's link#1
Open
cutiips wants to merge 1 commit intoRsyncProject:masterfrom
Open
Fix: use mailto: scheme instead of email: for Andrew Tridgell's link#1cutiips wants to merge 1 commit intoRsyncProject:masterfrom
cutiips wants to merge 1 commit intoRsyncProject:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the rsync website homepage to use the correct mailto: URI scheme so the maintainer email link works in modern browsers.
Changes:
- Replaced the non-standard
email:link scheme with the standardmailto:scheme for Andrew Tridgell’s email link.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
email:scheme is not recognized by modern browsers (e.g. Firefox, Safari), so clicking the link does nothing. Replacing it withmailto:(per RFC 6068) makes the link open the user's default mail app as expected.This is my first contribution to an open source repo, so I hope it's useful! :)