feat: persistent background task history (Phase 7c)#12354
Closed
roomote-v0[bot] wants to merge 2 commits into
Closed
feat: persistent background task history (Phase 7c)#12354roomote-v0[bot] wants to merge 2 commits into
roomote-v0[bot] wants to merge 2 commits into
Conversation
- Add background field to HistoryItem schema - Add interrupted status for background tasks stopped mid-execution - Add background option to TaskMetadataOptions - Detect and mark interrupted background tasks on TaskHistoryStore init - Add showBackgroundTasks filter to useTaskSearch hook - Add background task filter toggle to HistoryView UI - Add background/interrupted visual indicators in TaskItemFooter - Add i18n translation keys for background task labels - Add unit tests for all changes
2 tasks
|
@roomote Please fix the translation |
Contributor
Author
Added missing i18n translations for background task history keys ( |
Add backgroundTag, interruptedTag, showBackgroundTasks, hideBackgroundTasks, and filter.* keys to all 17 non-English locale files (ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW).
Contributor
Author
|
Closing in favor of consolidated PR #12356 which merges all Phase 7 work into a single PR as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #12330 (Phase 7c: Persistent Background Task History). Feedback and guidance are welcome.
Changes
Schema
background: boolean(optional) field toHistoryIteminpackages/types/src/history.tsinterruptedto the status enum (active | completed | delegated | interrupted) across all type definitionsCreateTaskOptions,TaskOptions, andTaskMetadataOptionsto acceptinterruptedstatusBackend
taskMetadata.ts: Addedbackgroundoption, propagated intoHistoryItemcreationTaskHistoryStore.ts: AddedmarkInterruptedBackgroundTasks()method that runs duringinitialize()to detect background tasks stuck inactivestate (e.g., VS Code closed mid-execution) and mark them asinterruptedTask.ts: ExtendedinitialStatustype to includeinterruptedUI
TaskItemFooter.tsx: Added visual indicators for background tasks (Layers icon) and interrupted tasks (AlertTriangle icon with warning color)useTaskSearch.ts: AddedshowBackgroundTasksfilter state (default: show) with filtering logicHistoryView.tsx: Added filter dropdown to toggle background task visibility (All Tasks / Foreground Only)CLI
TaskHistoryItemandHistoryResulttypes to includeinterruptedstatus andbackgroundfieldi18n
backgroundTag,interruptedTag,showBackgroundTasks,hideBackgroundTasks, andfilter.*Tests
TaskItemFooter(background tag, no background tag, interrupted tag, active background tag)useTaskSearch(shows background tasks by default, hides when toggled)TaskHistoryStore(marks active bg tasks as interrupted, skips completed bg tasks, skips non-bg active tasks)All 56 new and existing tests pass.
Interactively review PR in Roo Code Cloud