feat(sim): switch replay state to dynamic joints#301
Closed
juelg wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Closing this stacked PR per request. I’m moving the work back to the original master-based PR instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim_stateflow with dynamic joint statefr3_dual_armNotes
This PR is stacked on top of
feat/sim-state-record-replayand is meant to review only the follow-up that swaps the underlying replay state mechanism.The replay path still uses the original:
SimStateObservationWrapperscripts/replay_sim_trajectory.pypython/rcs/sim_state_replay.pypython/tests/test_sim_state_record_replay.pyBut the
Simstate implementation underneath now uses named dynamic-joint schema plus flat values, so scene-only changes do not break replay.Validation
make stubgenmake pyformatmake cppformatpython -m pip install -e .pytest -q python/tests/test_sim_state_record_replay.pypytest -q python/tests/test_multi_sim.py python/tests/test_sim_state_record_replay.py