Skip to content

Fix release-drafter v7 auth: env GITHUB_TOKEN -> with: token [MOD-15112]#965

Merged
dor-forer merged 1 commit intomainfrom
dorer-mod-15112-release-drafter-token
May 5, 2026
Merged

Fix release-drafter v7 auth: env GITHUB_TOKEN -> with: token [MOD-15112]#965
dor-forer merged 1 commit intomainfrom
dorer-mod-15112-release-drafter-token

Conversation

@dor-forer
Copy link
Copy Markdown
Collaborator

@dor-forer dor-forer commented May 5, 2026

Describe the changes in the pull request

Follow-up to #947 (which bumped release-drafter/release-drafter from v6 to v7).

In v7, authentication moved from the GITHUB_TOKEN environment variable to a token input (which defaults to ${{ github.token }}). The existing env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} block is now silently ignored.

The workflow currently still functions because v7 falls back to the default github.token, but the explicit token configuration is dead config — which would become a real problem if a PAT were ever needed here instead of the default token. This PR moves the token to the documented with: token: input so the original intent is preserved.

       - uses: release-drafter/release-drafter@v7
         with:
           # (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml
-           config-name: release-drafter-config.yml
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          config-name: release-drafter-config.yml
+          token: ${{ secrets.GITHUB_TOKEN }}

This fix will also be propagated to the open backport PRs (#960, #961, #962, #963, #964).

Which issues this PR fixes

  1. MOD-15112

Main objects this PR modified

  1. .github/workflows/release-drafter.yml

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Low Risk
Low risk workflow-only change that updates how the Release Drafter GitHub Action receives credentials; the main risk is misconfiguration causing release notes drafting to fail.

Overview
Updates the release-drafter GitHub Actions workflow to pass authentication via the v7-supported with: token input instead of the GITHUB_TOKEN environment variable, keeping the explicit secret-based token configuration effective.

Reviewed by Cursor Bugbot for commit 097d43f. Bugbot is set up for automated code reviews on this repo. Configure here.

@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 5, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@dor-forer dor-forer requested a review from BenGoldberger May 5, 2026 12:16
@dor-forer dor-forer marked this pull request as ready for review May 5, 2026 12:17
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (5ec2f77) to head (097d43f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         130      130           
  Lines        7749     7749           
=======================================
  Hits         7511     7511           
  Misses        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dor-forer dor-forer added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 12039c2 May 5, 2026
21 of 23 checks passed
@dor-forer dor-forer deleted the dorer-mod-15112-release-drafter-token branch May 5, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants