Skip to content

[8.4] ci: temporarily disable focal job in merge-queue and nightly flows (#954)#959

Merged
dor-forer merged 1 commit into8.4from
backport-954-to-8.4
May 6, 2026
Merged

[8.4] ci: temporarily disable focal job in merge-queue and nightly flows (#954)#959
dor-forer merged 1 commit into8.4from
backport-954-to-8.4

Conversation

@dor-forer
Copy link
Copy Markdown
Collaborator

@dor-forer dor-forer commented May 5, 2026

Backport of #954 to 8.4.

Auto-backport reported Git push to origin failed for backport-954-to-8.4 with exitcode 1. The cherry-pick itself applies cleanly on 8.4 (workflow shape matches main); the failure was on the bot's git push step, almost certainly a permissions/branch-protection issue specific to the backport bot's GitHub App on the 8.x branches. A manual push as the PR author succeeds, so this PR is opened that way.

Describe the changes in the pull request

Comment out the focal job (and its pr-validation.needs: entry) in both event-merge-to-queue.yml and event-nightly.yml, so the merge queue and nightly are no longer blocked by Ubuntu 20.04 CI failures caused by Canonical's PPA edge intermittently refusing connections.

See #954 for the full root-cause analysis. Diff is identical to main's (and to the 0.6 (#955), 0.7 (#956), 0.8 (#957), 8.2 backports modulo the workflow-shape differences).

Which issues this PR fixes

  1. Backport of ci: temporarily disable focal job in merge-queue and nightly flows #954.

Main objects this PR modified

  1. .github/workflows/event-merge-to-queue.ymlfocal job and its pr-validation.needs: entry commented out; # TODO re-enable marker added.
  2. .github/workflows/event-nightly.ymlfocal job and its notify-on-failure.needs: entry commented out.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Low Risk
Low risk: changes are limited to GitHub Actions workflow orchestration, removing the Ubuntu 20.04 (focal) CI leg from gating/notification dependencies.

Overview
Temporarily disables Ubuntu 20.04 CI by commenting out the focal job in event-merge-to-queue.yml and event-nightly.yml.

Updates downstream dependency lists (pr-validation.needs and notify-on-failure.needs) to stop requiring focal, and adds a TODO note to re-enable later.

Reviewed by Cursor Bugbot for commit 9dffd43. Bugbot is set up for automated code reviews on this repo. Configure here.

)

Launchpad's PPA infrastructure (ppa.launchpad.net / ppa.launchpadcontent.net)
has been intermittently refusing connections for several days, breaking
focal's install of gcc-11 from ppa:ubuntu-toolchain-r/test which is
required because focal needs gcc-11 for the SVS code path's C++20 features.

Comment out the focal job in both event-merge-to-queue.yml and
event-nightly.yml (and the corresponding entries in their respective
needs: lists) so the merge queue and nightly notifier are not blocked by
this upstream outage. focal.yml itself is untouched and remains
manually-triggerable via workflow_dispatch.

To be reverted once a durable solution (likely a pre-built CI image with
gcc-11 baked in, removing the per-run Launchpad dependency) is in place.

(cherry picked from commit fe17589)
@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented May 5, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@dor-forer dor-forer marked this pull request as ready for review May 5, 2026 10:54
@dor-forer dor-forer enabled auto-merge May 5, 2026 10:54
@dor-forer dor-forer requested review from BenGoldberger and GuyAv46 May 5, 2026 10:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.04%. Comparing base (b3ab13d) to head (9dffd43).

Additional details and impacted files
@@            Coverage Diff             @@
##              8.4     #959      +/-   ##
==========================================
- Coverage   97.06%   97.04%   -0.03%     
==========================================
  Files         126      126              
  Lines        7470     7470              
==========================================
- Hits         7251     7249       -2     
- Misses        219      221       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dor-forer dor-forer added this pull request to the merge queue May 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 5, 2026
@dor-forer dor-forer added this pull request to the merge queue May 5, 2026
@dor-forer dor-forer removed this pull request from the merge queue due to a manual request May 5, 2026
@dor-forer dor-forer added this pull request to the merge queue May 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 5, 2026
@dor-forer dor-forer added this pull request to the merge queue May 6, 2026
Merged via the queue into 8.4 with commit f391c2d May 6, 2026
21 of 23 checks passed
@dor-forer dor-forer deleted the backport-954-to-8.4 branch May 6, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants