Use new cached project count column (part 2 of 2)#805
Open
zetter-rpf wants to merge 1 commit intocache-submitted-countfrom
Open
Use new cached project count column (part 2 of 2)#805zetter-rpf wants to merge 1 commit intocache-submitted-countfrom
zetter-rpf wants to merge 1 commit intocache-submitted-countfrom
Conversation
Test coverage89.58% line coverage reported by SimpleCov. |
zetter-rpf
force-pushed
the
cache-submitted-count
branch
from
9def7db to
6ff71db
Compare
In [1] we started caching the value of submitted projects. Now we can use that value to simplify the code and reduce N+1 queries. [1] #804 Note that I've had to split the loading of remixes for teachers and students as teachers no longer need remixes (which causes bullet to complain) Co-authored-by: Copilot <copilot@github.com>
zetter-rpf
force-pushed
the
cache-submitted-count-part-2
branch
from
ed1ecb5 to
a503b60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MUST BE DEPLOYED AFTER #804
Status
Related to: https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1313
Follows on from: #804
What's changed?
In part 1 we started caching the value of submitted projects. Now we can use that value to simplify the code and reduce N+1 queries.