feat: Added support for custom input ARIA labels#9789
Open
lizschwab wants to merge 3 commits intoRaspberryPiFoundation:v13from
Open
feat: Added support for custom input ARIA labels#9789lizschwab wants to merge 3 commits intoRaspberryPiFoundation:v13from
lizschwab wants to merge 3 commits intoRaspberryPiFoundation:v13from
Conversation
mikeharv
reviewed
May 1, 2026
| this.bubble.focusableElement.getAttribute('role'), | ||
| 'group', | ||
| ); | ||
| suite('Input', function () { |
Contributor
There was a problem hiding this comment.
Could we consider moving this to a new ARIA suite at the bottom of input_test instead of here? The existing suite above is here because this block is all nested under Block>Icon management>Warning Icons.
I'm also considering moving the above suite to new file specifically for warnings, but I don't think you need to worry about that.
Contributor
Author
There was a problem hiding this comment.
Ah, gotcha. I didn't notice where this was nested, just that it was the only ARIA test group I found. I'll move it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9752
Proposed Changes
Adds a method to set a custom ARIA label to inputs when creating from javascript or when creating from JSON along with support for using that ARIA label if available or using the default if unavailable.
Reason for Changes
This allows developers to set their own ARIA labels for inputs when creating blocks.
Test Coverage
Unit tests are included. Manual testing was performed by updating the blocks defined in the playground and ensuring they are assigned the correct ARIA labels.