Skip to content

feat: Display keyboard shortcuts in context menus#9785

Open
gonfunko wants to merge 2 commits intov13from
menu-shortcuts
Open

feat: Display keyboard shortcuts in context menus#9785
gonfunko wants to merge 2 commits intov13from
menu-shortcuts

Conversation

@gonfunko
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #9739

Proposed Changes

This PR displays keyboard shortcuts associated with context menu items in the context menu. In general, shortcuts and context menu items that perform the same function should have the same name/ID; to avoid breaking backwards compatibility, a conversion map was added for preexisting built-in shortcuts.

@gonfunko gonfunko requested a review from a team as a code owner April 30, 2026 21:25
@gonfunko gonfunko requested a review from maribethb April 30, 2026 21:25
@github-actions github-actions Bot added the PR: feature Adds a feature label Apr 30, 2026
@gonfunko
Copy link
Copy Markdown
Contributor Author

gonfunko commented May 1, 2026

Refactored this to use associatedKeyboardShortcut as described in #9739. If present, it takes precedence; if not, matching falls back to id <-> name. This allows for lookup to succeed for legacy items without breaking changes, and for new ones the same ID/name should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feature Adds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants