Skip to content

Add Mooncake frule and rrule implementations#36

Merged
lkdvos merged 5 commits into
QuantumKitHub:mainfrom
kshyatt:ksh/mooncake
May 20, 2026
Merged

Add Mooncake frule and rrule implementations#36
lkdvos merged 5 commits into
QuantumKitHub:mainfrom
kshyatt:ksh/mooncake

Conversation

@kshyatt

@kshyatt kshyatt commented May 20, 2026

Copy link
Copy Markdown
Member

Moving these over here to be more generic in response to comments on QuantumKitHub/TensorKit.jl#436

@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.07%. Comparing base (b4acb15) to head (c250dc0).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
ext/VectorInterfaceMooncakeExt.jl 95.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   89.23%   93.07%   +3.84%     
==========================================
  Files           8       11       +3     
  Lines         325      491     +166     
==========================================
+ Hits          290      457     +167     
+ Misses         35       34       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos

lkdvos commented May 20, 2026

Copy link
Copy Markdown
Member

Oh god, this is going to be a compat nightmare

@kshyatt

kshyatt commented May 20, 2026

Copy link
Copy Markdown
Member Author

I'm sorry 😭

@kshyatt

kshyatt commented May 20, 2026

Copy link
Copy Markdown
Member Author

Although is anyone using 1.6 anymore? We could just drop it in CI, the Project.toml just shows julia = 1...

Comment thread ext/VectorInterfaceMooncakeExt.jl Outdated
Comment thread ext/VectorInterfaceMooncakeExt.jl Outdated

@Jutho Jutho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions but otherwise approved.

Co-authored-by: Jutho <Jutho@users.noreply.github.com>
@kshyatt

kshyatt commented May 20, 2026

Copy link
Copy Markdown
Member Author

Shouldn't we also take 1.6 out of CI, then?

@Jutho

Jutho commented May 20, 2026

Copy link
Copy Markdown
Member

Shouldn't we also take 1.6 out of CI, then?

Fine by me.

Comment thread Project.toml
@lkdvos lkdvos changed the title Add Mooncake fwd and rvs rules Add Mooncake frule and rrule implementations May 20, 2026
@lkdvos lkdvos merged commit 252809f into QuantumKitHub:main May 20, 2026
7 checks passed
@kshyatt kshyatt deleted the ksh/mooncake branch May 20, 2026 17:34
@lkdvos lkdvos mentioned this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants