fix(#605): opt the embedded WebView out of Google Safe Browsing#1349
Draft
jim-daf wants to merge 1 commit intoQuantumBadger:masterfrom
Draft
fix(#605): opt the embedded WebView out of Google Safe Browsing#1349jim-daf wants to merge 1 commit intoQuantumBadger:masterfrom
jim-daf wants to merge 1 commit intoQuantumBadger:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #605.
Background
On Android 8 and newer, every WebView request is checked against Google's Safe Browsing service unless the host application explicitly opts out. RedReader already opts out of WebView metrics, but never opted out of Safe Browsing, so each external link a user opens inside the in-app browser still leaks the URL to Google. The Android documentation lists the exact opt-out marker for this case.
Fix
Add the documented manifest meta-data right next to the existing
MetricsOptOutdeclaration so both privacy switches stay together.Why this is safe
Validation
aapt2 dump xmltreeon a built APK confirms the new meta-data lands inside<application>.safebrowsing.googleapis.com.