Add wasm test that input prompt using line not character buffering for stdin#146
Draft
ianthomas23 wants to merge 1 commit intomainfrom
Draft
Add wasm test that input prompt using line not character buffering for stdin#146ianthomas23 wants to merge 1 commit intomainfrom
ianthomas23 wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 88.22% 88.27% +0.05%
==========================================
Files 61 61
Lines 3065 2730 -335
Branches 330 330
==========================================
- Hits 2704 2410 -294
+ Misses 361 320 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct handling in WebAssembly of the input prompt used for commit messages (issue #44) was fixed in
cocklein jupyterlite/cockle#309. This PR adds a test to confirm the fix by using a backspace character in the input prompt to delete the previous character, thus confirming that stdin is using line buffering not individual character buffering.The new test is disabled if not running in WebAssembly. It already worked correctly in a manual test but running it via python's
subprocess.rundoesn't work without us using something more complicated like an input pipe to send the stdin characters, and that approach cannot work in WebAssembly so we'd have to implement some new workaround and it is not worth the effort.Closes #44.