Preserve QRF feature order during prediction#195
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1bc3fa7 to
f8a24cb
Compare
f8a24cb to
90ed3df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
not_numeric_categoricaloverrides through zero-inflated per-regime base imputers tooTests
uv run ruff check microimpute/models/qrf.py microimpute/models/zero_inflated.pyuv run python -m pytest -q tests/test_models/test_zero_inflated.py::TestSequentialPredictorTyping tests/test_models/test_qrf.py::test_qrf_model_prediction_reorders_to_fitted_feature_orderuv run python -m pytest -q tests/test_models/test_zero_inflated.pyuv run python -m pytest -q tests/test_models/test_qrf.pyNotes
This fixes the Stage 05 MP/eCPS regime-aware resume failure where a later chained QRF prediction saw the same feature names in a different order than fit. It also prevents continuous prior imputed targets from being dummy-encoded inside nested zero-inflated base fits when they become predictors for later targets.