Conversation
…bled state styling
…out, and define APP_VERSION in Vite config
andrew-welker
previously approved these changes
May 1, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves navigation and routing behavior in the Essentials Web Config App, including more flexible login routing, better UI feedback in navigation, and a routing-graph layout fix to avoid hidden devices impacting the diagram.
Changes:
- Refactors
TopNavnavigation links into a sharedAppNavLinkcomponent and adds an app version display sourced from a Vite global define. - Simplifies routing so the login form is reachable at both
/loginand/:appId/login. - Adjusts Routing graph edge construction so only visible devices/tie lines participate in Dagre layout calculations.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Adds global APP_VERSION define; formatting updates. |
| src/vite-env.d.ts | Declares global APP_VERSION for TypeScript. |
| src/styles.scss | Adds .nav-link-disabled styling. |
| src/features/TopNav.tsx | Introduces AppNavLink, disables nav links when no appId, shows version in navbar. |
| src/features/Routing.tsx | Filters layout edges to visible devices only to prevent hidden devices affecting layout. |
| src/features/MobileControl.tsx | Removes a debug console.log. |
| src/features/LoginForm.tsx | Improves appId fallback behavior and adds an application title above the login form. |
| src/features/InitializationExceptions.tsx | Fixes key usage by switching to keyed Fragment; removes console logging. |
| src/features/DebugConsole/DebugFilters.tsx | Changes clear button to outline-secondary. |
| src/App.tsx | Updates route structure for simplified login access. |
| package.json | Updates app version string. |
| tsconfig.tsbuildinfo | Removes generated TS build info file from the repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…safeAppId logic; refactor Routing and TopNav for improved readability and accessibility
andrew-welker
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the Essentials Web Config App, focusing on navigation usability, routing flexibility, and code consistency. The most significant changes are grouped below:
Navigation and Routing Enhancements
TopNav) to use a newAppNavLinkcomponent, which disables links when noappIdis selected and improves user feedback. Also added the app version display to the navigation bar. (src/features/TopNav.tsx,src/styles.scss, [1] [2] [3] [4]App.tsxto allow direct access to the login form for any:appIdand simplified the login route structure. (src/App.tsx, src/App.tsxL55-L60)Login and Authentication Improvements
appIdis invalid or missing, ensuring a smoother authentication flow. Also added a prominent application title above the login form. (src/features/LoginForm.tsx, [1] [2] [3] [4]Exception and Debug Console UI Refinements
Fragmentfor proper key assignment and removed unnecessary console logging. (src/features/InitializationExceptions.tsx, [1] [2] [3] [4] [5]outline-secondaryfor better visual consistency. (src/features/DebugConsole/DebugFilters.tsx, src/features/DebugConsole/DebugFilters.tsxL36-R36)Routing Visualization Logic
src/features/Routing.tsx, src/features/Routing.tsxR128-R141)Build and Configuration Updates
APP_VERSIONas a global define in the Vite config to make the app version accessible in the UI, and updated dependency versions and formatting for consistency. (vite.config.ts, [1] [2]package.json, [3]These changes collectively improve the user experience, code maintainability, and build process of the application.