Fix Blade Blast default stage cap#9837
Open
OursCodeur wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix Blade Blast default stage cap#9837OursCodeur wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
OursCodeur wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
Blade Blast uses a stage count for blade hits per cast/per second. Its modeled maximum was set to 900, so defaulting staged skills to their maximum stages overinflated Blade Blast damage. Use the skill tooltip cap of 50 blades instead and cover the default plus over-cap input. Fixes PathOfBuildingCommunity#9836
|
Why 50 stages? Lingering blades are capped to 40, so 50 is impossible unless the cap is per skill (which I don't think it is but am not sure of). |
Contributor
Author
|
Member
|
There's an infamous mod that gives more blades: "Skills that leave Lingering Blades have +(5-10) to Maximum Lingering Blades" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved
Fixes #9836.
Blade Blast was modeled with
Multiplier:BladeBlastMaxStagesset to 900. I aligned the internal value to the tooltip's so #9728 works as intended.Steps taken to verify a working solution