Check writing of initial values of sampled Variables#2622
Draft
erikvansebille wants to merge 1 commit intoParcels-code:mainfrom
Draft
Check writing of initial values of sampled Variables#2622erikvansebille wants to merge 1 commit intoParcels-code:mainfrom
erikvansebille wants to merge 1 commit intoParcels-code:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #2619, there is a bug in that the initial values of sampled Variables are not in the particle file. This PR provides a (failing) unit test to show that
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure