Support React 17

[prageeth]

This PR fixes #149 and ensures:

• that we can use React 17 as a peer dependency
• fixes some npm vulnerabilities using npm audit fix

[benprofitt]

Please release this fix, I love this package and I also love using the most recent version of react 😁
Super useful package, keep up the great work 👍

[prageeth]

@Paratron any chance this can be merged?

[fstn]

Need that to ... PLease merge it

[prageeth]

@benprofitt @fstn or anyone still stuck with this issue, you can use my branch directly from the git repo in the mean time. I use this in my own projets:

npm install hookrouter@pureartisan/hookrouter#master --save

[alvaradojl]

Please merge this so we can start using react 17! :)

[fstn]

Please Le sam. 20 mars 2021 à 08:51, Jorge Alvarado ***@***.***> a écrit :

…

Please merge this so we can start using react 17! :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#151 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWNAGKZQ5TBFKRAL6YW3L3TESZAHANCNFSM4WP67FKQ> .

[alvaradojl]

@benprofitt @fstn or anyone still stuck with this issue, you can use my branch directly from the git repo in the mean time. I use this in my own projets:

npm install hookrouter@pureartisan/hookrouter#master --save

I tried this command, package.json and package-lock.json are correctly updated, but the files in node_modules/hookrouter only contain a package.json and the README.md, I tried already to delete the folder and the package-lock but I always get the same output.

[prageeth]

I tried this command, package.json and package-lock.json are correctly updated, but the files in node_modules/hookrouter only contain a package.json and the README.md, I tried already to delete the folder and the package-lock but I always get the same output.

@alvaradojl It's possible that your global node cache still uses the old package.

Anyhow, I've just gone ahead and published a "patched" version with a few other fixes (open PRs).

npm i @patched/hookrouter@1.3.1

Let me know if you have any issues. You can also view the exact changes that are included here:
master...pureartisan:patched

NOTE: Your imports will ofcourse have to use @patched/hookrouter as the package name.

import { navgiate } from '@patched/hookrouter';

[mkayander]

I tried this command, package.json and package-lock.json are correctly updated, but the files in node_modules/hookrouter only contain a package.json and the README.md, I tried already to delete the folder and the package-lock but I always get the same output.

@alvaradojl It's possible that your global node cache still uses the old package.

Anyhow, I've just gone ahead and published a "patched" version with a few other fixes (open PRs).

npm i @patched/hookrouter@1.3.1

Let me know if you have any issues. You can also view the exact changes that are included here:
master...pureartisan:patched

NOTE: Your imports will ofcourse have to use @patched/hookrouter as the package name.

import { navgiate } from '@patched/hookrouter';

@prageeth Thanks for the patch, managed to get it working on React 17. The only problem i got was it missing the TS declarations. I copied them from the main version to a separate .d.ts file in my project, and it seems to work alright like this.

[ohchad]

I really liked this approach while it worked, but I can not have all these hacks in a production build and so, I'll be removing it from my project... wasted a lot of hours btw before finding this thread. You should merge your fix @prageeth and stop updating this thread.

[0xmvck]

I mean at this point @prageeth you should merge. @Patatron last update was 8 months ago

[prageeth]

Unfortunately I don’t have permissions to merge any PRs in this repo. Therefore, I’m using my own @patched/hookrouter package. I’ve recently published a few more fixes there. So if anyone wants to continue, please feel free to use it.