Skip to content

runtime fix #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ancavar wants to merge 2 commits into
base: 1.30
Choose a base branch
from
+3 −1
Open

runtime fix #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14fd879
fix stack boundary error
ancavar May 12, 2026
6f7f87b
fix readline errno error
ancavar May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ void update_references (memory_chunk *old_heap) {
heap_next_obj_iterator(&it);
}
// fix pointers from stack
scan_and_fix_region(old_heap, (void *)__gc_stack_top + sizeof(size_t), (void *)__gc_stack_bottom + sizeof(size_t));
Copy link
Copy Markdown
Collaborator

@danyaberezun danyaberezun May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to skip a word from __gc_stack_bottom?

Copy link
Copy Markdown
Contributor Author

@ancavar ancavar May 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought __gc_stack_bottom is meant to be exclusive? e.g.

Lama/runtime/gc.c

Line 244 in f52beb0

for (size_t *p = (size_t *)(__gc_stack_top + sizeof(size_t)); p < (size_t *)__gc_stack_bottom; ++p) {

Copy link
Copy Markdown
Collaborator

@danyaberezun danyaberezun May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is exclusive, no?
line 334

scan_and_fix_region(old_heap, (void *)__gc_stack_top + sizeof(size_t), (void *)__gc_stack_bottom);

// fix pointers from extra_roots
scan_and_fix_region_roots(old_heap);
Expand Down
2 changes: 2 additions & 0 deletions runtime/runtime.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,6 +1186,8 @@ extern void Lfclose (FILE *f) {
extern void *LreadLine () {
char *buf;

errno = 0;

if (scanf("%m[^\n]", &buf) == 1) {
void *s = Bstring((aint*)&buf);

Expand Down
Loading