I updated the DocBox version to use the v5.0.2#346
Conversation
|
| } | ||
| ); | ||
| docbox = new docbox.DocBox() | ||
| .addStrategy( "HTML", { |
There was a problem hiding this comment.
@DavisVega1990 This is wrong. Why did you change the strategy? That's not the right one. The command docs needs to use the actual CommandBox strategy
|
|
||
| <!-- Zip API Docs --> | ||
| <zip destfile="${dist.dir}/${distro.name}-apidocs-${commandbox.version}.zip" basedir="${temp.dir}/apidocs"></zip> | ||
| <zip destfile="${dist.dir}/${distro.name}-apidocs-${commandbox.version}.zip" basedir="${temp.dir}/apidocs/CommandBox-CommandDocs"></zip> |
There was a problem hiding this comment.
Why did you change this directory?
There was a problem hiding this comment.
I updated the directory name because, when I switched to DocBox version 5 in the tests I ran with the incorrect Strategy = HTML, the project returned the error message: "The directory CommandBox-CommandDocs does not exist." This meant the directory had to be created before generating the files.
For this reason, I set the directory name as a prerequisite to generating the files.
| }, | ||
| "devDependencies":{ | ||
|
|
||
| "docbox":"https://github.com/Ortus-Solutions/DocBox/archive/v5.0.2.zip" |
There was a problem hiding this comment.
Please change this to use a proper Forgebox slug@vesrion. I'm not even sure why it was using a direct URL to start.
3 participants
Description
Please include a summary of the changes and which issue(s) is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please note that all PRs must have tests attached to them
Type of change
Updated the DocBox version to use v5.0.2 to improve the UI and the SEO requirements
Please delete options that are not relevant.
Checklist