remove pe_serverversion fact#247
Open
corporate-gadfly wants to merge 1 commit intoOpenVoxProject:mainfrom
Open
remove pe_serverversion fact#247corporate-gadfly wants to merge 1 commit intoOpenVoxProject:mainfrom
corporate-gadfly wants to merge 1 commit intoOpenVoxProject:mainfrom
Conversation
Contributor
|
looks good to me, but we should wait with the merge until the next minor release. Then we can do the breaking changes. |
bastelfreak
added
the
backwards-incompatible
corporate-gadfly
force-pushed
the
remove-pe_serverversion
branch
from
dc5416f to
739860b
Compare
Signed-off-by: Corporate Gadfly <haroon.rafique@gmail.com>
corporate-gadfly
force-pushed
the
remove-pe_serverversion
branch
from
739860b to
0d93530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.