Support podman in tasks/build.rake#227
Conversation
|
I opened #228 before I noticed this PR. The approach there is even simpler, but requires the use of the Building other OpenVox components, such as |
|
No worries. Any interest in me reworking this to remove the dependency on the shim? |
|
Using environment variables to pick a CLI implementation seems reasonable to me. Perhaps |
6a79a0b to
cba84c5
Compare
cba84c5 to
5bcc181
Compare
Sharpie
left a comment
There was a problem hiding this comment.
Looks good to me 👍
Thanks for the contribution!
Support podman in addition to docker in tasks/build.rake via the DOCKER environment variable. Signed-off-by: Greg NISBET <gregorynisbet@google.com>
Head branch was pushed to by a user without write access
b7e5863 to
03e9260
Compare
|
Hi, so I can keep the PR up to date with respect to main (which I did just now with a force push), but I don't know the procedure for actually merging the PR. Auto-merge was enabled prior to my last push, but I wasn't able to merge it at that time. Is two committers' approval needed for a PR to be merged? |
Support podman in addition to docker in tasks/build.rake via the DOCKER environment variable.
Pull Request (PR) description
I did the simplest thing I could think of to make
DOCKER=podman rake vox:buildsucceed.There are a few differences between
--format jsonfor Docker and podman, but I still thinkthat that's the most robust way to get the commands to emit structured output.
I'm curious whether folks think this is worth doing at all, and whether an environment variable
is the best way of achieving this (and also whether shell substitution is better than doing the
conditional at the ruby level)
This Pull Request (PR) fixes the following issues
n/a