Skip to content

Add spatial and temporal to dataset #309#310

Merged
Ludee merged 8 commits into
developfrom
feature-309-dataset-spatial-temporal
May 8, 2026
Merged

Add spatial and temporal to dataset #309#310
Ludee merged 8 commits into
developfrom
feature-309-dataset-spatial-temporal

Conversation

@Ludee
Copy link
Copy Markdown
Member

@Ludee Ludee commented May 7, 2026

Summary of the discussion

  • Add spatial information to dataset
  • Add temporal information to dataset
  • Remove topics from dataset

Type of change (CHANGELOG.md)

Added

  • Add spatial information to dataset (#310)
  • Add temporal information to dataset (#310)

Removed

Workflow checklist

Automation

Closes #309

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee requested a review from jh-RLI May 7, 2026 22:00
@Ludee Ludee self-assigned this May 7, 2026
@Ludee Ludee added priority: critical 🔥 Critical priority part: backend 🧱 Backend component type: feature 🛠 New feature or request status: active 🚧 Work in progress labels May 7, 2026
@Ludee Ludee marked this pull request as ready for review May 7, 2026 22:02
Copy link
Copy Markdown
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, as it looks correct to me. I wasn't aware that we would remove the topics completely. I used that field in some scripts, but this does not mean i strongly want to keep it. In general we should harmonize the OEP topics with the subjects at some point.

@Ludee
Copy link
Copy Markdown
Member Author

Ludee commented May 8, 2026

You are right, I thought I remove it from the dataset but deleted it from resource.
I added the topics again since it is needed for the OEP.
The resources have 3 different classification systems:

  • topics (fix set of database schemas)
  • subject (ontology terms, structured but extendable)
  • keywords (user chaos)

@Ludee Ludee merged commit fd5b5cd into develop May 8, 2026
3 checks passed
@Ludee Ludee deleted the feature-309-dataset-spatial-temporal branch May 8, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part: backend 🧱 Backend component priority: critical 🔥 Critical priority status: active 🚧 Work in progress type: feature 🛠 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new dataset keys for spatial, temporal

2 participants