Skip to content

fix(config): reject object router model refs#187

Open
MicroMilo wants to merge 1 commit into
OpenBMB:mainfrom
MicroMilo:codex/reject-object-router-model-refs
Open

fix(config): reject object router model refs#187
MicroMilo wants to merge 1 commit into
OpenBMB:mainfrom
MicroMilo:codex/reject-object-router-model-refs

Conversation

@MicroMilo

Copy link
Copy Markdown

Summary

  • reject non-string router model references during config validation
  • keep router.scenarios.default synced as the runtime-supported provider/model string
  • add regression coverage for object-shaped router refs and sync behavior

Verification

  • npm --workspace ui exec vitest run server/services/pilotdeckConfig.router-model-ref.test.js
  • npm exec -- tsc --noEmit -p tsconfig.json

Notes

This is a real UI/runtime contract mismatch: the runtime accepts provider/model strings, while the previous UI validator silently ignored object-shaped refs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant