Feature/no sardine#784
Merged
Merged
Conversation
added 5 commits
May 2, 2026 17:36
Remove the `sardine-android` dependency and implement WebDAV functionality (PROPFIND, MKCOL, MOVE, PUT, DELETE) directly using OkHttp and a custom XML parser.
- **WebDavRepository**: Replaced Sardine's `list` with a manual `PROPFIND` request and `XmlPullParser` to fetch folder contents.
- **WebDavConduit**:
- Migrated single and chunked upload logic to use OkHttp `Request` objects.
- Implemented manual WebDAV operations: `headExists`, `headContentLength`, `mkcol`, `move`, and `webdavDelete`.
- Improved chunked upload efficiency by using `HEAD` requests instead of `PROPFIND` to check for existing chunks.
- Added support for cancelling active network calls.
- **Conduit**: Wrapped `jobFailed` logic in `NonCancellable` to ensure database updates and event broadcasts complete during service shutdown.
- **SaveClient**: Removed the `getSardine` helper as it is no longer required.
- **Dependencies**: Removed `guardianproject-sardine` from Gradle configuration and updated app version to 4.0.15.
- Upgrade AGP to 9.1.1, Compose to 1.11.0, Kotlin to 2.3.21, and Koin to 4.2.1. - Update various library versions including Datastore, Firebase Crashlytics, Gson, Material3, Media3, Mixpanel, OkHttp, and Tor-Android. - Remove unused or redundant dependencies and plugins, such as BouncyCastle, Bitcoinj, Guava, Netcipher, and ConstraintLayout. - Clean up unused library definitions for Picasso, Jsoup, and several Google Play/MLKit components.
Introduce a standalone `SugarToRoomMigrator` object to facilitate the synchronous migration of records from Sugar ORM to Room. Key changes: - Implement `migrate()` to sequence the migration of Spaces, Projects, Collections, and Media. - Add `migrateSpaces()` to map `SugarSpace` to `VaultEntity` and handle credential storage. - Add `migrateProjects()` to map `SugarProject` to `ArchiveEntity`. - Add `migrateCollections()` to map `SugarCollection` to `SubmissionEntity`. - Add `migrateMedia()` to map `SugarMedia` to `EvidenceEntity`, including status mapping. - Update `MigrationStateEntity` throughout the process to track migration stages.
…tore Ensures the DataStore is a process-wide singleton for the credential file, preventing conflicts between migration-time and Koin-injected instances. - Implement a thread-safe `getOrCreateDataStore` pattern in the companion object. - Update the `dataStore` property to use the shared singleton instance. - Adjust visibility of internal security constants.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.