feat: update cluster setup scripts for ONTAP 9 unified compatibility#31
Open
mahatvagarg wants to merge 3 commits into
Open
feat: update cluster setup scripts for ONTAP 9 unified compatibility#31mahatvagarg wants to merge 3 commits into
mahatvagarg wants to merge 3 commits into
Conversation
|
Test Report looks present - thanks. Reviewers will verify the captured output and idempotency evidence. |
hvinn
previously approved these changes
May 13, 2026
…ve variable handling
hvinn
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update cluster setup scripts for ONTAP 9 unified compatibility. Simplifies node discovery by removing version-specific field-set fallback logic and using a single unified field set that works across all ONTAP 9.x releases.
Changes
cluster_setup_basic.py): Replaced 3-tier_NODE_FIELDS_SETSfallback with a single_NODE_FIELDStuple; removed shebang and orchestrio reference.cluster_setup.yml): Removeddisaggregated,san_optimizedfromnode_query_fields; updated play name.Checklist
General
If touching
python/python -m py_compile python/*.py)ruff check python/)If touching
ansible/ansible-playbook --syntax-check)ansible-lintpassesTest Report
Environment: N/A — cannot run end-to-end
Platform version: Target: ONTAP 9.8+
Style touched: python, ansible
Static verification
python3 -m py_compile python/cluster_setup_basic.py— OKansible/cluster_setup.yml— OKdisaggregated,san_optimized); no new API calls, no logic changes.Cannot run on a cluster?
This script performs initial cluster creation from unclustered nodes — it requires
two fresh ONTAP Simulator VMs in pre-cluster state. The change is a pure simplification:
_NODE_FIELDS_SETS) with a single_NODE_FIELDStuple using the base ONTAP 9 fields. No behavioral change for ONTAP 9.8+.disaggregated,san_optimizedfromnode_query_fieldsto match.Both files compile/parse cleanly. The removed fields (
disaggregated,san_optimized)were only available on ONTAP 9.18+/9.19+ — removing them makes the scripts work uniformly
across all ONTAP 9.x versions without the fallback retry loop.
Please apply the
needs-test-runlabel so a maintainer with an unclustered simulatorenvironment can validate before merge.
Related issues