Skip to content

Bugfix/cstackex 155: Fix VM provisioning after a pool comes out of maintenance mode #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piyush5netapp wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

Bugfix/cstackex 155: Fix VM provisioning after a pool comes out of maintenance mode #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b56255
bugfix/CSTACKEX-155: Fix cancel maintain for vm provisioning
May 12, 2026
6e94d34
bugfix/CSTACKEX-155: Fix cancel maintain for vm provisioning update c…
May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion ...src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,29 @@ public boolean maintain(DataStore store) {
@Override
public boolean cancelMaintain(DataStore store) {
logger.info("Cancelling storage pool maintenance for {}", store);

// Save capacity before the generic cancelMaintain path overwrites it.
// The generic flow sends ModifyStoragePoolCommand to agents. For managed iSCSI pools,
// IscsiAdmStoragePool returns capacityBytes=0 , With capacity=0,
// the deployment planner's checkPoolforSpace rejects the pool ("No destination found").
StoragePoolVO poolVO = storagePoolDao.findById(store.getId());
long savedCapacityBytes = poolVO.getCapacityBytes();
long savedUsedBytes = poolVO.getUsedBytes();

if (_dataStoreHelper.cancelMaintain(store)) {
return _storagePoolAutomation.cancelMaintain(store);
boolean result = _storagePoolAutomation.cancelMaintain(store);

// Restore capacity
poolVO = storagePoolDao.findById(store.getId());
if (poolVO.getCapacityBytes() == 0 && savedCapacityBytes > 0) {
logger.info("Restoring storage pool {} capacity to {} bytes",
poolVO.getName(), savedCapacityBytes);
poolVO.setCapacityBytes(savedCapacityBytes);
poolVO.setUsedBytes(savedUsedBytes);
storagePoolDao.update(poolVO.getId(), poolVO);
}

return result;
} else {
return false;
}
Expand Down
Loading