refactor(server): unify policy persistence in objects table#972
Open
johntmyers wants to merge 1 commit intomainfrom
Open
refactor(server): unify policy persistence in objects table#972johntmyers wants to merge 1 commit intomainfrom
johntmyers wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
Collaborator
Author
|
/ok to test ed81ed9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves sandbox policy revisions, draft policy chunks, and settings persistence onto the unified
objectstable for the greenfield OS-103 schema.It replaces the old dedicated policy/chunk tables, switches singleton settings writes to name-based upserts, and adds handler-level coverage for the draft chunk lifecycle.
Related Issue
Linear: OS-103
Changes
objectsschema and remove the old002/003policy-specific migrationsPolicyRevisionPayloadandDraftChunkPayloadwrappers in the proto layer and update persistence backends to store policy revisions and draft chunks insideobjectsname, update sandbox teardown cleanup, and tighten CAS retry logic to use typed unique-constraint handlingTesting
mise run pre-commitpassesCommands run:
cargo fmt --all -- --checkRUSTC_WRAPPER= cargo test -p openshell-server persistence::tests -- --nocaptureRUSTC_WRAPPER= cargo test -p openshell-server sandbox_settings_save_and_load_round_trip -- --nocaptureRUSTC_WRAPPER= cargo test -p openshell-server delete_unlock_sandbox_set_succeeds_after_global_delete -- --nocaptureRUSTC_WRAPPER= cargo test -p openshell-server draft_chunk_handler_lifecycle_round_trip -- --nocaptureRUSTC_WRAPPER= cargo test --manifest-path e2e/rust/Cargo.toml --features e2e --test host_gateway_alias -- --nocaptureRUSTC_WRAPPER= UV_NO_SYNC=1 uv run pytest python/openshell/sandbox_test.py -k no_verifyRUSTC_WRAPPER= mise run e2e:rustRUSTC_WRAPPER= mise run e2e:pythonmise run pre-commitwas attempted but is still blocked locally by two non-branch issues: ignoredarchitecture/plans/*files without SPDX headers and the workspaceopenshell-provertest link step failing withld: library 'z3' not found.Checklist