feat(openshell-vm): add tty support for exec#939
Open
benoitf wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
add support on both side (rust and python) fixes NVIDIA#936 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add TTY support for openshell-vm exec, enabling interactive terminal sessions inside VMs.
Both the Rust host (client-side raw mode, terminal resize propagation) and the Python guest agent (PTY allocation, resize handling) are updated to support the new tty flag
openshell-exec-tty.mov
Related Issue
#936
Changes
Testing
mise run pre-commitpassesChecklist