Skip to content

feat(server): add object meta convention to top-level objects#919

Open
derekwaynecarr wants to merge 1 commit intoNVIDIA:mainfrom
derekwaynecarr:feat/864-object-metadata/derekwaynecarr
Open

feat(server): add object meta convention to top-level objects#919
derekwaynecarr wants to merge 1 commit intoNVIDIA:mainfrom
derekwaynecarr:feat/864-object-metadata/derekwaynecarr

Conversation

@derekwaynecarr
Copy link
Copy Markdown
Contributor

@derekwaynecarr derekwaynecarr commented Apr 22, 2026

Summary

Add object meta convention to top-level objects.

  • adds filterable label selectors on resources

Related Issue

Closes #864

Changes

  • add object meta to top level domain objects
  • add ability to filter sandboxes in key/value pairs
  • update tui / cli to render fields

Testing

  • [x ] mise run pre-commit passes
  • [ x] Unit tests added/updated
  • [ x] E2E tests added/updated (if applicable)

Checklist

  • [ x] Follows Conventional Commits
  • [ x] Commits are signed off (DCO)
  • [ x] Architecture docs updated (if applicable)

@derekwaynecarr derekwaynecarr requested a review from a team as a code owner April 22, 2026 18:01
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026 •
edited
Loading

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@derekwaynecarr
Copy link
Copy Markdown
Contributor Author

derekwaynecarr commented Apr 22, 2026

I have read the DCO document and I hereby sign the DCO.

@derekwaynecarr
Copy link
Copy Markdown
Contributor Author

derekwaynecarr commented Apr 22, 2026

recheck

@derekwaynecarr
Copy link
Copy Markdown
Contributor Author

derekwaynecarr commented Apr 22, 2026

Just a note for the reviewer, I had intended to add resource_version, but the change grew large and decided to defer that to a later time.

@TaylorMutch
Copy link
Copy Markdown
Collaborator

TaylorMutch commented Apr 22, 2026

@derekwaynecarr can you resolve the branch conflicts?

@TaylorMutch TaylorMutch self-assigned this Apr 23, 2026
@derekwaynecarr derekwaynecarr force-pushed the feat/864-object-metadata/derekwaynecarr branch from 3cda77c to b5935a0 Compare April 23, 2026 16:54
@derekwaynecarr
Copy link
Copy Markdown
Contributor Author

derekwaynecarr commented Apr 23, 2026

@TaylorMutch rebased and pushed, thanks!

@derekwaynecarr derekwaynecarr force-pushed the feat/864-object-metadata/derekwaynecarr branch 2 times, most recently from ec09a00 to ded972c Compare April 23, 2026 17:45
@derekwaynecarr
Copy link
Copy Markdown
Contributor Author

derekwaynecarr commented Apr 23, 2026

/recheck

@derekwaynecarr
Copy link
Copy Markdown
Contributor Author

derekwaynecarr commented Apr 23, 2026

recheck

@derekwaynecarr derekwaynecarr force-pushed the feat/864-object-metadata/derekwaynecarr branch from ded972c to 0e6d0ff Compare April 23, 2026 20:35
@johntmyers
Copy link
Copy Markdown
Collaborator

johntmyers commented Apr 23, 2026

Does https://github.com/derekwaynecarr/OpenShell/blob/0e6d0fff319a9c8a1b52cc3fbe9014016b998d51/python/openshell/sandbox.py#L195 need to be updated to response.sandbox.metadata.id or just use _sandbox_ref(response.sandbox)?

@derekwaynecarr derekwaynecarr force-pushed the feat/864-object-metadata/derekwaynecarr branch from 0e6d0ff to 9d6c2a1 Compare April 24, 2026 00:35
@derekwaynecarr
Copy link
Copy Markdown
Contributor Author

derekwaynecarr commented Apr 24, 2026

@johntmyers rebased and fixed up python and corresponding e2e.

@johntmyers johntmyers added the test:e2e Requires end-to-end coverage label Apr 24, 2026
@johntmyers johntmyers self-assigned this Apr 24, 2026
@derekwaynecarr derekwaynecarr force-pushed the feat/864-object-metadata/derekwaynecarr branch 3 times, most recently from 32931cf to ddf2e40 Compare April 24, 2026 22:18
@johntmyers
Copy link
Copy Markdown
Collaborator

johntmyers commented Apr 24, 2026

/ok to test 9d6c2a1

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 24, 2026

/ok to test 9d6c2a1

@johntmyers, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@johntmyers
Copy link
Copy Markdown
Collaborator

johntmyers commented Apr 24, 2026

/ok to test 9d6c2a1

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 24, 2026

/ok to test 9d6c2a1

@johntmyers, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@johntmyers
Copy link
Copy Markdown
Collaborator

johntmyers commented Apr 24, 2026

/ok to test ddf2e40

@derekwaynecarr
feat(server): add object meta convention to top-level objects
46a37df 
- adds filterable label selectors on resources

Closes NVIDIA#864

Signed-off-by: Derek Carr <decarr@redhat.com>
@derekwaynecarr derekwaynecarr force-pushed the feat/864-object-metadata/derekwaynecarr branch from ddf2e40 to 46a37df Compare April 24, 2026 22:30
@johntmyers
Copy link
Copy Markdown
Collaborator

johntmyers commented Apr 24, 2026

/ok to test 46a37df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@johntmyers johntmyers

@TaylorMutch TaylorMutch

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add Kubernetes-style metadata to all domain objects

3 participants

@derekwaynecarr @TaylorMutch @johntmyers