Skip to content

fix(cli): require explicit gpu sandbox flag#1835

Merged
elezar merged 1 commit into
mainfrom
no-issue-remove-gpu-image-inference/el
Jun 10, 2026
Merged

fix(cli): require explicit gpu sandbox flag#1835
elezar merged 1 commit into
mainfrom
no-issue-remove-gpu-image-inference/el

Conversation

@elezar

@elezar elezar commented Jun 9, 2026

Copy link
Copy Markdown
Member

Summary

Remove the CLI behavior that inferred GPU sandbox mode from the selected sandbox image name. GPU resources are now requested only when the user passes --gpu.

Related Issue

None.

Changes

  • Use the explicit --gpu flag as the sole source of SandboxSpec.gpu.
  • Remove the image-name GPU detection helper and its dedicated unit tests.
  • Update CLI help and README wording so docs no longer describe implicit GPU inference.

Testing

  • mise run pre-commit passes
  • Focused Rust tests run: cargo test -p openshell-cli sandbox_should_persist
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

@copy-pr-bot

copy-pr-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@elezar elezar marked this pull request as ready for review June 9, 2026 13:47
@elezar elezar requested review from a team and mrunalp as code owners June 9, 2026 13:47
@mrunalp

mrunalp commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 344395d

@elezar elezar added the test:e2e-gpu Requires GPU end-to-end coverage label Jun 10, 2026
@elezar elezar self-assigned this Jun 10, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e-gpu applied for 344395d. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute GPU E2E after building the required supervisor image once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

BREAKING CHANGE: GPU sandbox mode is no longer inferred from sandbox image names. Users must pass --gpu to request GPU resources.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the no-issue-remove-gpu-image-inference/el branch from 344395d to 3765da4 Compare June 10, 2026 07:52
@elezar elezar requested a review from derekwaynecarr as a code owner June 10, 2026 07:52
@elezar elezar enabled auto-merge (squash) June 10, 2026 07:57
@elezar elezar merged commit 27fd31c into main Jun 10, 2026
21 of 22 checks passed
@elezar elezar deleted the no-issue-remove-gpu-image-inference/el branch June 10, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e-gpu Requires GPU end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants