fix(cli): require explicit gpu sandbox flag#1835
Merged
Merged
Conversation
Collaborator
|
/ok to test 344395d |
SDAChess
approved these changes
Jun 10, 2026
|
Label |
BREAKING CHANGE: GPU sandbox mode is no longer inferred from sandbox image names. Users must pass --gpu to request GPU resources. Signed-off-by: Evan Lezar <elezar@nvidia.com>
344395d to
3765da4
Compare
alangou
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the CLI behavior that inferred GPU sandbox mode from the selected sandbox image name. GPU resources are now requested only when the user passes
--gpu.Related Issue
None.
Changes
--gpuflag as the sole source ofSandboxSpec.gpu.Testing
mise run pre-commitpassescargo test -p openshell-cli sandbox_should_persistChecklist