Skip to content

Example in documentation showing color computation for a reddened source#446

Merged
hhsieh00 merged 8 commits into
mainfrom
445-docs-add-example-color-of-reddened-source
May 14, 2026
Merged

Example in documentation showing color computation for a reddened source#446
hhsieh00 merged 8 commits into
mainfrom
445-docs-add-example-color-of-reddened-source

Conversation

@hhsieh00
Copy link
Copy Markdown
Collaborator

@hhsieh00 hhsieh00 commented May 6, 2026

adding new example to spectroscopy documentation for computing the color of a reddened source in specified filters from sbpy.photometry.bandpass

added new example to spectroscopy documentation for computing the color of a reddened source in specified filters from sbpy.photometry.bandpass
@hhsieh00 hhsieh00 linked an issue May 6, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.81%. Comparing base (59a8a49) to head (46cecae).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files          53       53           
  Lines        4267     4267           
=======================================
  Hits         3491     3491           
  Misses        776      776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hhsieh00 hhsieh00 requested a review from mkelley May 6, 2026 02:10
@hhsieh00
Copy link
Copy Markdown
Collaborator Author

hhsieh00 commented May 6, 2026

@mkelley Okay, ready for review! I'd note that running sun = Sun.from_builtin("calspec") returns AstropyDeprecationWarning warnings, but that seems like it might be an issue to deal with separately.

Copy link
Copy Markdown
Member

@mkelley mkelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. I'll fix that deprecation warning.

Comment thread docs/sbpy/spectroscopy/index.rst Outdated
Comment thread docs/sbpy/spectroscopy/index.rst Outdated
Comment thread docs/sbpy/spectroscopy/index.rst Outdated
- created new section for added example
- added units to 18% spectral gradient
- added note that user-defined bandpasses can be added using synphot.spectrum.Spectral.Element
@hhsieh00
Copy link
Copy Markdown
Collaborator Author

Thanks for the comments, @mkelley . Ready for another look.

Copy link
Copy Markdown
Member

@mkelley mkelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hhsieh00 hhsieh00 merged commit e720e46 into main May 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Add example on how to calculate the color of a reddened source.

2 participants