Example in documentation showing color computation for a reddened source#446
Conversation
added new example to spectroscopy documentation for computing the color of a reddened source in specified filters from sbpy.photometry.bandpass
|
Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 53 53
Lines 4267 4267
=======================================
Hits 3491 3491
Misses 776 776 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
to ensure all necessary imports and dependencies are available
|
@mkelley Okay, ready for review! I'd note that running |
mkelley
left a comment
There was a problem hiding this comment.
A few comments. I'll fix that deprecation warning.
- created new section for added example - added units to 18% spectral gradient - added note that user-defined bandpasses can be added using synphot.spectrum.Spectral.Element
|
Thanks for the comments, @mkelley . Ready for another look. |
adding new example to spectroscopy documentation for computing the color of a reddened source in specified filters from sbpy.photometry.bandpass