Skip to content

sync the updates#161

Draft
sohailxi wants to merge 4 commits into
Moustachauve:mainfrom
sohailxi:main
Draft

sync the updates#161
sohailxi wants to merge 4 commits into
Moustachauve:mainfrom
sohailxi:main

Conversation

@sohailxi
Copy link
Copy Markdown

No description provided.

sohailxi and others added 2 commits February 8, 2026 18:50
Signed-off-by: Md Sohail <83342804+sohailxi@users.noreply.github.com>
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 23, 2026
Signed-off-by: Md Sohail <83342804+sohailxi@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces home screen widgets to control WLED devices directly from the home screen. It includes a configuration activity for device selection, a widget provider for triggering presets, and a remote views service for displaying the preset list. Feedback focuses on improving the reliability of asynchronous operations in the widget provider by using goAsync(), externalizing hardcoded strings to resources for better localization, and ensuring stable IDs for the widget's list items to improve consistency.

Comment thread README.md
Comment thread app/src/main/AndroidManifest.xml
Copy link
Copy Markdown
Author

@sohailxi sohailxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync the fork

@Moustachauve
Copy link
Copy Markdown
Owner

Hi, thanks for the contribution. As a standard practice, I don't review pull requests that lack a description—especially large ones. Please update the PR body with a clear summary of what this is, why it's necessary, and how it should be tested. I'll hold off on diving into the code until that context is added.

I'll mark this PR as a draft until then.

@Moustachauve Moustachauve marked this pull request as draft April 24, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants