fix(mcpack): replicate external subplatform support from mcmanifest#1608
Open
HipsterBrown wants to merge 1 commit intoModdable-OpenSource:publicfrom
Open
fix(mcpack): replicate external subplatform support from mcmanifest#1608HipsterBrown wants to merge 1 commit intoModdable-OpenSource:publicfrom
HipsterBrown wants to merge 1 commit intoModdable-OpenSource:publicfrom
Conversation
Collaborator
|
Thanks for catching this and for making the change to keep them in sync. I noticed recently that xs-dev defaults to mcpack for new projects. That's a great way to make sure mcpack gets exercised. |
Contributor
Author
|
Yea, my approach for xs-dev these days is to be a bridge for JS developers to the embedded world by providing a familiar workflow, I.e. package.json as the primary manifest, the polyfilled APIs provided by mcpack, and ECMA-419 first. It will always support manifest.json and all the ways Moddable projects that can be built. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External subplatform (a.k.a custom device targets) support was added in Moddable v8.1.0 but only in mcmanifest.js for
mcconfigto resolve. This PR creates parity support formcpackas well.