feat(bindings): tile and bin functions parity — emitters / table functions / getters#102
Closed
estebanzimanyi wants to merge 1 commit into
Closed
feat(bindings): tile and bin functions parity — emitters / table functions / getters#102estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
estebanzimanyi
added a commit
that referenced
this pull request
May 5, 2026
…istance Parity tests activated (21/23 files now pass; 2 tile/split files remain skipped pending table-function architecture, tracked by PRs #102/#110): 015_span_aggfuncs — SetUnionAgg / SpanUnionAgg / extent (20 assertions) 022_temporal — temporal accessors + operators (32 assertions) 032_temporal_box — tbox constructors + expandValue/expandTime (3 assertions) 032_temporal_topops — temporal @> tbox / && temporal / -|- tstzspan (3 assertions) 036_tnumber_distance — tint<->tint, nad, nearestApproachDistance (3 assertions) 040_temporal_aggfuncs — TcountAgg/TandAgg/TminAgg/TsumAgg/extent (5 assertions) 042_temporal_waggfuncs — WminAgg/WmaxAgg/WsumAgg (3 assertions) 050_geo_inventory — geo surface manifest activated (1 assertion) 009_time_ops — tstzset/tstzspan + interval shift; tstzspan <-> INTERVAL (4 assertions) Bug fixes: - tstzspan/tstzset <-> operator: was registered as INTERVAL but implementation returned double, causing INTERNAL crash. Fixed Distance_span_value, Distance_value_span (use distance_span_timestamptz), Distance_span_span (dispatch on T_TSTZSPAN), Distance_set_value/Distance_value_set/ Distance_set_set (tstzset case). All time-type distances now return interval_t normalised to days+micros so "2 days" formats correctly. - expandValue(tbox, INTEGER): TboxExpandValueExecutor<int64_t> caused INTERNAL error "Expected vector of type INT64, but found vector of type INT32". Fixed template parameter to int32_t. - SetUnionAgg(date): date_to_set called raw DuckDB date_t without epoch offset conversion, producing dates 30 years in future. Added date_to_set_duckdb wrapper using ToMeosDate(). New registrations: - "+", {tstzset, INTERVAL} → tstzset: shift alias (MobilityDB @> parity) - "+", {tstzspan, INTERVAL} → tstzspan: shift alias - SecondsToInterval helper in time_util.hpp Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
estebanzimanyi
added a commit
that referenced
this pull request
May 10, 2026
…istance Parity tests activated (21/23 files now pass; 2 tile/split files remain skipped pending table-function architecture, tracked by PRs #102/#110): 015_span_aggfuncs — SetUnionAgg / SpanUnionAgg / extent (20 assertions) 022_temporal — temporal accessors + operators (32 assertions) 032_temporal_box — tbox constructors + expandValue/expandTime (3 assertions) 032_temporal_topops — temporal @> tbox / && temporal / -|- tstzspan (3 assertions) 036_tnumber_distance — tint<->tint, nad, nearestApproachDistance (3 assertions) 040_temporal_aggfuncs — TcountAgg/TandAgg/TminAgg/TsumAgg/extent (5 assertions) 042_temporal_waggfuncs — WminAgg/WmaxAgg/WsumAgg (3 assertions) 050_geo_inventory — geo surface manifest activated (1 assertion) 009_time_ops — tstzset/tstzspan + interval shift; tstzspan <-> INTERVAL (4 assertions) Bug fixes: - tstzspan/tstzset <-> operator: was registered as INTERVAL but implementation returned double, causing INTERNAL crash. Fixed Distance_span_value, Distance_value_span (use distance_span_timestamptz), Distance_span_span (dispatch on T_TSTZSPAN), Distance_set_value/Distance_value_set/ Distance_set_set (tstzset case). All time-type distances now return interval_t normalised to days+micros so "2 days" formats correctly. - expandValue(tbox, INTEGER): TboxExpandValueExecutor<int64_t> caused INTERNAL error "Expected vector of type INT64, but found vector of type INT32". Fixed template parameter to int32_t. - SetUnionAgg(date): date_to_set called raw DuckDB date_t without epoch offset conversion, producing dates 30 years in future. Added date_to_set_duckdb wrapper using ToMeosDate(). New registrations: - "+", {tstzset, INTERVAL} → tstzset: shift alias (MobilityDB @> parity) - "+", {tstzspan, INTERVAL} → tstzspan: shift alias - SecondsToInterval helper in time_util.hpp Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
Member
Author
Cross-reference:
|
estebanzimanyi
added a commit
that referenced
this pull request
May 10, 2026
Two new docs: - docs/PR-COORDINATION.md — ecosystem policy: gh pr list is the first step before any code change; don't duplicate or conflict with in-flight PRs/policies. Cross-ecosystem variant. One PR = one commit = one feature consolidation rule with the git commit-tree squash recipe. - docs/CONSOLIDATION-PLAN.md — working artefact mapping the file-level overlap between commits already on main and the open consolidate/* parity PRs (#97/#98/#99/#100/#102/#103/#104) plus PR #111 (per-thread MEOS init). Three resolution options per overlap (rebase / revert+fold / keep both); maintainer picks per PR. Pre-emptive policy preventing the duplication and policy-conflict failures that produced the consolidate/* / main overlap and the single-timezone / per-thread-MEOS-init clash.
…tions / getters Brings the tile and bin function surface to parity with MobilityDB: - Bin emitters: timeBin, valueBin, spaceBin, valueTimeBin, spaceTimeBin scalar forms returning the bin span/box for a given input. - Tile emitters: timeTiles, valueTiles, spaceTiles, valueTimeTiles, spaceTimeTiles table-function forms returning the LIST of bins covering the input domain. - Tile getters: getBin, getValueBin, getTimeBin, getSpaceBin family scalar forms looking up the bin index for a value. - Tpoint-specific tile emitters covering the spatial dimensions. Includes the RegisterTemporalTileSplit implementation (timeSplit/valueSplit/valueTimeSplit) — table functions emitting the SETOF (bin, sliced_temporal) tuples that DuckDB requires.
estebanzimanyi
force-pushed
the
consolidate/tiles-bins-parity
branch
from
a37e63d to
c42bdc8
Compare
estebanzimanyi
added a commit
that referenced
this pull request
May 10, 2026
…nsolidates #115 + #119) Three related artefacts that prevent the same class of failure (parallel work on the same surface drifting in policy and offset state): docs/PR-COORDINATION.md — ecosystem policy: gh pr list is the first step before any code change; minimise PR count by folding into existing PRs; squash each PR to a single commit before review. Cross-ecosystem variant for MobilityDB / JMEOS / PyMEOS / MobilitySpark / MEOS-API. docs/CONSOLIDATION-PLAN.md — file-level overlap matrix between commits already on main and the open consolidate/* parity PRs (#97/#98/#99/ #100/#102/#103/#104) plus PR #111 (per-thread MEOS init); three resolution options per overlap. Working artefact, delete once consolidations land. scripts/lint-tz-pinned-tests.py — flags every line in an expected-output block that carries a hardcoded UTC offset. Pre-commit gate / CI lint. Today reports 734 hits across 43 files; the lint makes the timezone-neutral migration trackable. scripts/parity-audit.py — adds an OUT_OF_SCOPE_NAMES bucket for function names that are out-of-scope by domain (not by suffix pattern): - transform_gk: Gauss-Krüger projection added to MobilityDB for the SECONDO platform integration; no equivalent need in MobilityDuck. - create_trip: BerlinMOD synthetic-trip generator; runs in MobilityDB / SECONDO and emits parquet artefacts that MobilityDuck consumes — MobilityDuck does not need to host the generator itself. Pairs naturally with PR #111 / commit 9dd765a's timezone-neutral test policy: the doc tells contributors what to do, the lint enforces it, the parity audit reflects realistic coverage now that two domain- specific names are off the missing list.
Member
Author
|
Superseded by the consolidated parity batch at #126 ( The work on this branch — tile and bin functions parity — emitters / table functions / getters — is now part of the squashed addressable-parity surface that brings MobilityDuck to 943/943 = 100.0% of the active addressable temporal + geo names. Closing to keep the review queue focused on the three active stacked PRs (#126 → #130 → #129) and the four orthogonal PRs (#105 / #111 / #113 / #117 / #120). Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates 6 individual parity PRs (previously #62, #79, #81, #82, #85, #88) into one squashed commit.
Test plan
test/sql/parity/025_temporal_tile_getters.testtest/sql/parity/026_single_tile_getters.testtest/sql/parity/058_tile_emitters.testtest/sql/parity/059_split_path.test🤖 Generated with Claude Code